fix: recover viewer post-processing after duplicate scene mutations#228
Merged
fix: recover viewer post-processing after duplicate scene mutations#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Duplicating elements can mutate the scene graph in a way that trips the current post-processing pipeline. The existing retry path increments
pipelineVersion, but the rebuild effect was not keyed off that state, so the pipeline never actually rebuilt. On top of that, when the pipeline was unavailable the render loop returned early, which could leave the viewer without a normal fallback render.Fixes #223.
Verification
npx -y @biomejs/biome check packages/viewer/src/components/viewer/post-processing.tsxnpx -y react-doctor@latest . --verbose --diff(packages/viewer scored 99/100, warning-only)